https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 --- Comment #110 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #109)
4. I am not sure about the desk_id parameter we passed to Koha::Hold->set_waiting. We could also set it from ModReserveAffect, what's the benefit of this approach?
I felt it was a good thing having it at the set_waiting level. In part because it encourages code to be written cleanly in the Koha:: space and because I feel it's the set_waiting call that links closely with when a desk would be assigned to a reserve and as such having it in this function now means if we use set_waiting down the line without calling ModReserveAffect then we would be reminded to set desk_id if appropriate. -- You are receiving this mail because: You are watching all bug changes.