https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39355 Bug ID: 39355 Summary: New sample notices are added in English during database migration/Koha upgrade, instead of being transalted Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: schodkowy.omegi-0r@icloud.com QA Contact: testopia@bugs.koha-community.org Full list of sample notices is specified in this file: https://github.com/Koha-Community/Koha/blob/6cffdc70059d04e39507cc94d58c226e... It is translatable and used by the installer to fill up the "letters" table with sample notices in our selected languages at the time of Koha installation. However, if a Koha upgrade is ran, database migrations are ran, such as these two: - https://github.com/Koha-Community/Koha/blob/6cffdc70059d04e39507cc94d58c226e... - https://github.com/Koha-Community/Koha/blob/6cffdc70059d04e39507cc94d58c226e... Unfortunately, these migrations add new notices with sample hardcoded English text of the notice, with a discord of its definition in sample_notices.yml (which might also mean the text is different, if someone adjusts the default in one place but not another). In practice all new notices that were added after the installation are in English, instead of the instance language. Expected behavior: the migrations should add the new notices from sample_notices.yml, in the same language as those set up during the installation. Caveat: I am not sure what determines/saves that primary language. You can have your default OPAC and staff languages be English, your default Linux system locale also be English, while the notices might be another language. I failed to find where that original language might be saved. Also to be clear: this is about the situation where TranslateNotices pref is DISABLED. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.