https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35142 --- Comment #13 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Martin Renvoize (ashimema) from comment #4)
There's a possible regression here lurking.. raw vs. ViewPolicy-filtered records in the OPAC displays.
Solved this. Multi-tasking had me have a branch with this fixed but never submitted! (In reply to Martin Renvoize (ashimema) from comment #9)
Reusing those tested helpers would keep a single source of truth rather than re-duplicating the logic the patch set out to de-duplicate. But, the counter-argument is that the inlined version is self-contained and readable.?
I like the end result, and the are no more places using that anymore. If we find a good use case for having helper subs we can move the snippets into class methods. But I doubt it for now! -- You are receiving this mail because: You are watching all bug changes.