https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38895 --- Comment #5 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Jonathan Druart from comment #4)
Maybe I don't understand the problem, but for me your patch introduces a regression.
I put a "#" on purpose (maybe it's silly, I was just trying to break your patch!).
Before the patch: Editor: 008 250123b ||||#||| |||| 00| 0 eng d Marc detail: @ 250123b ||||#||| |||| 00| 0 eng d
After the patch: Editor: 008 250123b |||| ||| |||| 00| 0 eng d The # disappeared here. Marc defailt: @ 250123b ||||#||| |||| 00| 0 eng d
I didn't find differences when not using "#".
Well, depends of what are you starting with. If you already have # in 008, it will not show in the editor, like any other character put at the position where it is not legal (= not present at the list). For instance, if you had 008/29 = '2' in the record you would see _ in the editor. The main point is not to introduce '#' in 008, because this is not legal character. There should be an empty character (= space) where in the MARC 21 documentation (https://loc.gov/marc/bibliographic/bd008b.html) is used '#' ('#' is conventional character in MARC 21 doc for a blank). This is what our "traditional" editor does - it shows '#' in the legend but puts ' ' (a blank) into 008 and this is right. The advanced editor before the patch puts '#' in the content of the 008 which is undoubtedly wrong. Please start with an empty record without and with the patch, modify 008 using '#' in the advanced editor, save it and look at the data to see the effect. -- You are receiving this mail because: You are watching all bug changes.