https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40294 --- Comment #74 from Jan Kissig <bibliothek@th-wildau.de> --- (In reply to Pedro Amorim (ammopt) from comment #72)
Thanks Jan, the test passes reliably now but I'm not certain this is the fix we want.
1) patrons_self_renewal.t: the $category in the 'submit()' subtest (line 116) doesn't set enforce_expiry_notice, so it's random and the print-only count (lines 180, 186) just hides that. Could we set enforce_expiry_notice => 0 and keep the original ->search (all notices)? 2) Koha/Patron.pm line 3403 seems to not be needed: the loop already skips a second 'print' via $print_sent (line 3419). I believe it should go back to the original line, can you please verify?
Hey Pedro, 1) I fixed the test according your advice and disabled the mandatory expiry notice for the patron category in the test. 2) Yeah completely right. I only saw the 2 print notices being generated while debugging, directly implemented a check and didn't read the sub to the end. Now its reverted. -- You are receiving this mail because: You are watching all bug changes.