https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Status|Passed QA |Failed QA --- Comment #37 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi all, the logging itself works well. One thing to fix first: The new logging test passes even when nothing is logged 1) Open t/Members_Messaging.t and add this as a new line right after line 317 (subtest 'SetMessagingPreference logs undef for removed digest and days values'): require t::lib::Mocks; t::lib::Mocks::mock_preference('BorrowersLog', 0); 2) Run: prove -v t/Members_Messaging.t 3) Notice both "is logged as undef" checks still pass, although logging is switched off and nothing was logged. When nothing is logged, $calls[-1] is undef, so both checks compare undef with undef. Please mock 'BorrowersLog' to 1 and check that the expected entries were actually logged (e.g. the number of calls), so the test fails if logging breaks. Also, has_digest and takes_days (added to GetMessagingPreferences and returned by GetPatronMessagingPreferences) aren't mentioned in the commit message and don't appear to be used or needed. Can we please confirm? -- You are receiving this mail because: You are watching all bug changes.