https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16262 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50244|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 50275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50275&action=edit Bug 16262 - Remove the use of "onclick" from acquisitions basket template In order to bring the acquisitions basket template into compliance with coding guideline JS9, this patch changes with way some JavaScript events are handled by moving JS handling out of the HTML markup. Also changed: Replaced the use of [% script_name %] (which is undefined), with the actual script path. To test, apply the patch and locate an open basket in Acquisitions which has more than one order in it. - Test the "Managed by: Add user" button and verify that it triggers a popup where you can search for patrons. - Select two or more patrons to be managers for the basket. - Close the search windows and confirm that your choices appear on the basket page. - Click "Delete user" next to one of the patrons. The patron should be removed. - Click "Save changes" and verify that your choices are correctly saved. - Click "Delete user" next to one of the remaining patrons. The patron should be removed. - Click "Save changes" and verify that the patron stays deleted. - In the list of orders, click the "Transfer" link and confirm that the correct pop-up window is triggered. - Test the "Delete this basket" button in the toolbar. A modal window should be triggered. - In a basket with orders: - The "Delete basket and orders" button should do what it says, leaving associated bibliographic records intact. - The "Delete basket, orders, and records" button should do what it says, deleting any bibliographic records associated with orders. - In a basket with no orders: - The "Delete basket" button should work correctly. - Test the "Create edifact order" button. - Click "Send EDI order" on the resulting page. - In the resulting dialog, "Are you sure you want to generate an edifact order," verify that both the "Yes" and "No" options work correctly. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.