http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30310&action=edit [PASSED QA] Bug 12457: Adding unit tests for Members.pm Adding unit tests for the routines AddMessage, GetMessages, GetMessagesCount and DeleteMessage in t/db_dependent/Members.t Adding unit tests for the routines GetPendingIssues and GetAllIssues in separate files : t/db_dependent/Members/GetPendingIssues.t and t/db_dependent/Members/GetAllIssues.t The routine GetAllIssues has been modified because it does not test if the arguments was defined : - the borrowernumber argument is required - if the order argument is not given, it takes a value by default : 'date_due desc' - the limit argument is optional Test plan: 1/ Apply the patch 2/ Execute : prove t/db_dependent/Members.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/GetPendingIssues.t 3/ The result has to be a success without error or warning : t/db_dependent/Members.t ................... ok t/db_dependent/Members/GetAllIssues.t ...... ok t/db_dependent/Members/GetPendingIssues.t .. ok All tests successful. Files=3, Tests=83, 5 wallclock secs ( 0.06 usr 0.01 sys + 4.68 cusr 0.26 csys = 5.01 CPU) Result: PASS Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: perltidy on t/db_dependent/Members/* Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.