http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: I am not sure at all but the check on the notforloan value should not be made in the CanItemBeReserved routine ? Is not it more relevant ? If not, your patch has to be resubmitted for a little modification. The test in IsAvailableForItemLevelRequest is: return ($available_per_item and ($item->{onloan} or GetReserveStatus($itemnumber) eq "W" or $item->{notforloan} < 0)); it will be optimized if you change the order, as: return ($available_per_item and ($item->{onloan} or $item->{notforloan} < 0 or GetReserveStatus($itemnumber) eq "W" )); Marked as Failed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.