https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36716 Bug ID: 36716 Summary: Need a better way of looping through smart-rules ( circ table ) columns Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When a user clicks "Edit" ( .editrule ) we use JavaScript to loop through each of the columns in the table. This is done based on the column index like so: if ( i == 3 ) or } else if ( i == 5 || i == 6 || i == 26 || i == 27 || i == 28 || current_input_id === "holds_pickup_period" ) { This leads to problems like Bug 36708. We could probably give the columns names/classes so we don't have to rely on the index, which may vary between Koha versions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.