https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41801 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Nick Clemens (kidclamp) from comment #6)
(In reply to David Nind from comment #5)
I don't think this is working correctly: 1. Place 150 holds: perl ./randhold.pl -b 312 -n 150 2. Note the details for the first hold (priority = 1) (I copied the info in the note column) 3. Click the button to move the hold with priority 1 to "Move hold to the bottom" 4. It becomes the hold with priority of 79, instead of the bottom, with is hold with the priority of 150 5. I tried this in reverse, the bottom one to "Move hold to the top" (priority = 150), this became the hold with priority = 80
Hi David,
Can you confirm the requests you are looking at are marked as 'lowest priority'? The column between 'Details' and 'Delete' has two down arrows pointing down - when there is a line udner this, the hold is marked 'lowest priority' and cannot be moved above a hold that is not marked this way, and vice versa.
These are the holds that cause the performance hit and are expected to work this way
I was testing in the wrong place 8-) I was using the tick box (first column), Priority (second column), and Change priority (third column) to change the priority; not the double down arrow between the Details and Delete columns. The patch does indead improve the performance, from around 20 seconds to 2 seconds. However, I don't really understand what it is doing, so will leave to someone who is more familiar with it to test. Observed behavour: 1. The holds with the "Set lowest priority" icon (double down arrow without the underline) are listed with a priority of 1 to 64 2. Action performed: "Set lowest priority" for the first hold in the list: - Had a priority of 1, priority changed to 150, label for arrow was "Set lowest priority", moves down to bottom of the holds list, 2.08s - Icon doesn't change: still says "Set lowest priority" 3. Action performed: "Remove lowest priority" for the item with a current priority of 149: - Had a priority of 149, priority changed to 150, 2.14s - Icon changed to "Set lowest priority" - The hold that previously had a priority of 150 (from step 2), now has a priorty of 65, with the "Set lowest priority" icon (no change to icon) -- You are receiving this mail because: You are watching all bug changes.