https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #32)
Marcel, the tests do not cover your changes, they pass without the first patch.
Thanks for looking to this report. There is no module change here, so there is no test to prove it like you have in mind. But I added a testcase to illustrate my point. Yes, it passes with and without the patch. But if you look to the test, it demonstrates that we need the change applied to the script. Maybe overcomplete, but imo no reason to fail QA. -- You are receiving this mail because: You are watching all bug changes.