http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8453 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #13)
Hi Nicole and Owen,
I agree, It is a lot of discussion for a little patch. But I think this kind of patch should have never exist :)
Let me explain you why.
When I arrived on this patch to make QA, I thought: it is an easy patch. I was surprised to find an unique space for a patch. I didn't know we wanted to add space after a input radio.
Apparently, I am not alone in this case. My job as a part of QA team is to put in question each patch. I think this one should not have exist, because the ajustement between input and label should automatically be taken into account. Otherwise, for each patch adding these lines, inevitably a patch will have to be created to fix that. It's not very productive, I think. Given that, we can fix that definitely and don't create a new patch for each space to add.
You patch works well, but it fixes one problem rather than fixing all futur problems
Marking as Passed QA
We're not really consistent: * moremember.pl page (patron adding) show yes [] no [] for flags & sex (checkbox on the right of the label) * the inventory.pl page show the checkbox on the left, description is not clicable * the tools/holidays.pl page show the checkbox on the left, the description itself is clickable My preference goes to what we have in tools/holidays.pl, but let me know your's. Should we start a discussion on koha-devel for that ? In the meantime, this patch is pushed, even if i'm not a fan of the space (owen, your voice is a leader one for all what is related to interface for me) -- You are receiving this mail because: You are watching all bug changes.