https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383 --- Comment #96 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 209756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209756&action=edit Bug 42383: (follow-up) Match legacy behaviour for blocked, bundle, waiting-hold, claim and local-use checkins Round out the Vue checkin page so the remaining returns.pl use cases match the legacy behaviour: - Blocked check-ins (e.g. wrong branch) open a "Cannot check in" modal with the destination library and accompanying-materials note - The bundle verification status column is consistent (Verified / Not verified / Lost) - The waiting-holds alert names the patron (via the checkout.patron embed) and is shown first - The return-claim modal shows the lost/fee check-in messages inline and uses the standard button palette and "Ignore" idiom - Not-issued items are checked in directly via x-koha-override, recording local use when RecordLocalUseOnReturn is set - "Print slip and confirm" for holds and recalls ports bug 42505: an empty popup is opened during the click (so it is not blocked) and the hold slip is only loaded into it after the confirm_hold/confirm_recall call succeeds, so waitingdate/expirationdate are current on the first print. The popup is closed if the confirmation fails. Test plan: 1. Exercise each of the above checkin scenarios on the Vue checkin page => SUCCESS: behaviour and layout match the legacy returns page 2. Set HoldsAutoFill to "Don't", add Waiting since: [% hold.waitingdate | $KohaDates %] to the HOLD_SLIP notice, check in an item with a hold for the check-in library and click "Print slip and confirm" => SUCCESS: The popup is not blocked and the slip shows today's waiting date on the first print 3. prove t/db_dependent/api/v1/checkins.t => SUCCESS 4. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) Assisted-by: Opus 5.5 (Anthropic) Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.