http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 39229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39229 [SIGNED-OFF] Bug 14118: Silence warnings t/DataTables/Members.t Review of attachment 39229: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14118&attachment=39229) ----------------------------------------------------------------- Not blocker. ::: C4/Utils/DataTables/Members.pm @@ +103,4 @@
my $limit; # If iDisplayLength == -1, we want to display all patrons + if ( !$dt_params->{iDisplayLength} || $dt_params->{iDisplayLength} > -1 ) {
What about if ( not $dt_params->{iDisplayLength} or $dt_params->{iDisplayLength} > -1 ) { @@ +107,3 @@
# In order to avoid sql injection + $dt_params->{iDisplayStart} =~ s/\D//g if defined($dt_params->{iDisplayStart}); + $dt_params->{iDisplayLength} =~ s/\D//g if defined($dt_params->{iDisplayLength});
useless use of parenthesis. -- You are receiving this mail because: You are watching all bug changes.