https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39771 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181644|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182080&action=edit Bug 39771: Make `data` attribute nullable for jobs This patch makes the `data` attribute nullable. This happens when `$job->finish()` is called with no parameters. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/jobs.t => FAIL: Tests don't pass, a 500 is returned when `finish()` was called with no data 3. Apply this patch 4. Rebuild the API spec: k$ yarn api:bundle 5. Repeat 2 => SUCCESS: Tests pass! The API doesn't explode 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.