https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38081 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172366|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172449&action=edit Bug 38081: maskitoTimeOptionsGenerator does not properly support 12-hour times in calendar.inc This patch corrects an issue where flatpickr time-only input boxes boxes were not having their inputs masked (limited) properly due to maskitoTimeOptionsGenerator not properly supporting 12-hour time inputs for time-only input boxes. To test: 1. Login to the staff intranet. 2. Open Administration->Libraries-> Edit any library. 3. Open your browser's development console (typically via F12) Verify a 'TypeError' message has been thrown for this page. 4. Type in any text into any of the opening hours This should be limiting only to properly formatted HH:MM. 5. Apply patch 6. Repeat steps 2-4 Verify no errors show on your browser's development console. Verify opening hours entry are limited to proper HH:MM format. 7. Open Administration->System Preferences and change TimeFormat to 12-hours, Save. 8. Repeat steps 2-4 Verify opening hours text entry are limited to properly formatted HH:MM AM/PM (or am/pm) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.