https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Some preliminary QA comment on the first patch only: Smart perl tidy: Removing Sip:: and adding $server. If I only had such a smart perl tidy :) Seriously, we should not do ANY changes if we say that a patch is a perltidy patch. Changes should be in another patch! < $resp .= $lang . Sip::timestamp();
$resp .= $lang . timestamp(); < $resp .= maybe_add( FID_SCREEN_MSG, $patron->screen_msg ); < $resp .= maybe_add( FID_SCREEN_MSG, $patron->{branchcode} ) $resp .= maybe_add( FID_SCREEN_MSG, $patron->screen_msg, $server ); $resp .= maybe_add( FID_SCREEN_MSG, $patron->{branchcode}, $server ) < $resp .= 'YYYY' . ( ' ' x 10 ) . $lang . Sip::timestamp(); $resp .= 'YYYY' . (' ' x 10) . $lang . timestamp();
Interestingly, this cuddled else disappears too. But note that xt/perltidyrc contains a --cuddled-else. Note that I do not like cuddled else, but somewhere in time the community decided that we should use it. (Nothing better than discussion about tabs or curly braces..) - } else { + } + else { Your tidy patch also contains constructs like (variable) instead of the preferred ( variable ). Two simple examples: < foreach my $i ( keys(%handlers) ) {
foreach my $i (keys(%handlers)) { < my ( $class, $msg, $seqno ) = @_; my ($class, $msg, $seqno) = @_; So, it appears that you did not use the default Koha perltidyrc but some other one. By conclusion, I will add a new perl tidy patch and extract your real changes in a separate patch.
-- You are receiving this mail because: You are watching all bug changes.