http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11393|0 |1 is obsolete| | Attachment #11427|0 |1 is obsolete| | Attachment #11441|0 |1 is obsolete| | --- Comment #36 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11460&action=edit Bug 7417 follow-up: incorporate QA comments This patch incorporates the following QA comments: * Renames Koha::Authority to Koha::DataObject::Authority * Uses Modern::Perl instead of 'use strict; use warnings;' * perltidied all new files again * wrote an intelligent constructor for Koha::DataObject::Authority which takes a hash with the construction criteria * added rudimentary error handling in C4::AuthoritiesMarc::GetAuthority * added missing t/AuthoritiesMarc.t This patch also improves test coverage, and eliminates the need for a database to test the EmbedSeeFromHeadings RecordProcessor plugin. In order to make the Koha codebase more consistent, this patch switches the RecordProcessor and Koha::DataObject::Authority code to use the Moose-like syntax supported by Class::Accessor. Squashed follow-up. -- You are receiving this mail because: You are watching all bug changes.