https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42418 --- Comment #83 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 204914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204914&action=edit Bug 42418: (QA follow-up) Add full coverage for _attach_messages_to_checkin _attach_messages_to_checkin (moved back to C4::Circulation in the previous follow-up) had no coverage at all, direct or indirect - existing tests only ever assert on AddReturn's legacy $messages hashref, never on the Koha::Checkin object_messages this function actually produces. It's a large function (~185 lines, 27 recognised message keys), so cover it directly rather than trying to drive all 27 through real AddReturn scenarios, following the existing precedent in this file of calling C4::Circulation private subs directly in tests (_GetCircControlBranch, _FixOverduesOnReturn). Test plan: 1. prove t/db_dependent/Circulation.t => SUCCESS: 92 tests pass, all 27 message keys exercised. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.