https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Comment on attachment 79018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79018 Bug 13272: Adds type="text" to inputs missing it
From e7b302d7bec099e387a4689c084acea7cf4fab23 Mon Sep 17 00:00:00 2001 From: Christopher Brannon <cbrannon@cdalibrary.org> Date: Sun, 16 Sep 2018 22:06:10 +0000 Subject: [PATCH] Bug 13272: Adds type="text" to inputs missing it
TEST PLAN: 1) Apply the patch. 2) Track the changes in the patch and make sure the changes don't alter behavior of the text box or page. --- koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc | 5 +++-- koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 6 +++--- .../intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 6 +++--- koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt | 6 +++--- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt | 4 ++-- 17 files changed, 31 insertions(+), 30 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc index b49fd5d..8d665d8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc @@ -59,8 +59,8 @@ <fieldset class="rows" id="manual_restriction_form"> <legend>Add manual restriction</legend> <ol> - <li><label for="rcomment">Comment:</label> <input type="text" id="rcomment" name="comment" /></li> - <li><label for="rexpiration">Expiration:</label> <input name="expiration" id="rexpiration" size="10" value="" class="datepicker" /> + <li><label for="rcomment">Comment:</label> <input type="text" id="rcomment" name="comment" type="text" /></li> + <li><label for="rexpiration">Expiration:</label> <input name="expiration" id="rexpiration" size="10" value="" class="datepicker" type="text" /> <a href="#" class="clear-date" id="clear-date-rexpiration">Clear date</a></li> </ol> <fieldset class="action"><input type="submit" value="Add restriction" /> <a href="#" class="cancel" id="cancel_manual_restriction">Cancel</a></fieldset> diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc index 0737885..215ebaf 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-search.inc @@ -9,14 +9,15 @@ <div id="checkin_search" class="residentsearch"> <p class="tip">Scan a barcode to check in:</p> <form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off"> - <input class="head-searchbox" name="barcode" id="ret_barcode" size="40" /> + <input class="head-searchbox" name="barcode" id="ret_barcode" size="40" type="text" /> + <input value="Submit" class="submit" type="submit" /> </form> </div> <div id="renew_search" class="residentsearch"> <p class="tip">Scan a barcode to renew:</p> <form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off"> - <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" /> + <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" type="text" /> <input value="Submit" class="submit" type="submit" /> </form> </div> diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc index 6cb15b0..e94b3e4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc @@ -8,14 +8,14 @@ <div id="checkin_search" class="residentsearch"> <p class="tip">Scan a barcode to check in:</p> <form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off"> - <input class="head-searchbox" name="barcode" id="ret_barcode" size="40" accesskey="r" /> + <input class="head-searchbox" name="barcode" id="ret_barcode" size="40" accesskey="r" type="text" /> <input value="Submit" class="submit" type="submit" /> </form> </div> <div id="renew_search" class="residentsearch"> <p class="tip">Scan a barcode to renew:</p> <form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off"> - <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" /> + <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" type="text" /> <input value="Submit" class="submit" type="submit" /> </form> </div> diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc index 9c4f4ee..3b6d0a0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc @@ -8,14 +8,14 @@ <div id="checkin_search" class="residentsearch"> <p class="tip">Scan a barcode to check in:</p> <form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off"> - <input name="barcode" class="head-searchbox" id="ret_barcode" size="40" accesskey="r" /> + <input name="barcode" class="head-searchbox" id="ret_barcode" size="40" accesskey="r" type="text" /> <input value="Submit" class="submit" type="submit" /> </form> </div> <div id="renew_search" class="residentsearch"> <p class="tip">Scan a barcode to renew:</p> <form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off"> - <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" /> + <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" type="text" /> <input value="Submit" class="submit" type="submit" /> </form> </div> diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc index 72405d8..b56fab9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc @@ -123,14 +123,14 @@ <div id="checkin_search" class="residentsearch"> <p class="tip">Scan a barcode to check in:</p> <form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off"> - <input class="head-searchbox" name="barcode" id="ret_barcode" size="40" accesskey="r" /> + <input class="head-searchbox" name="barcode" id="ret_barcode" size="40" accesskey="r" type="text" /> <input value="Submit" class="submit" type="submit" /> </form> </div> <div id="renew_search" class="residentsearch"> <p class="tip">Scan a barcode to renew:</p> <form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off"> - <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" /> + <input class="head-searchbox" name="barcode" id="ren_barcode" size="40" type="text" /> <input value="Submit" class="submit" type="submit" /> </form> </div> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt index 79bd43b..6ceb352 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt @@ -167,7 +167,7 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : [% IF ( show_nextbutton ) %] <input type="button" name="changepage_next" value="Next page" data-currentpage="[% current_page | html %]" /> [% END %] - <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page | html %]" size="4" /><input type="submit" name="changepage_goto" value="Go" /> + <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page | html %]" size="4" type="text" /> <input type="submit" name="changepage_goto" value="Go" /> </form>
[% ELSE %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt index 5bc7e00..e90dd87 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ -532,9 +532,9 @@ [% END %] </select> </td> - <td><input name="maxissueqty" size="3" /></td> - <td><input name="maxonsiteissueqty" size="3" /></td> - <td><input name="max_holds" size="3" /></td> + <td><input name="maxissueqty" size="3" type="text" /></td> + <td><input name="maxonsiteissueqty" size="3" type="text" /></td> + <td><input name="max_holds" size="3" type="text" /></td> <td class="actions"><button type="submit" class="btn btn-default btn-xs"><i class="fa fa-plus"></i> Add</td> </tr> </table> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt index 7a4a279..a9b10e9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt @@ -144,7 +144,7 @@ [% IF ( show_nextbutton ) %] <input type="button" name="changepage_next" value="Next page" data-currentpage="[% current_page | html %]" /> [% END %] - <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page | html %]" size="4" /><input type="submit" name="changepage_goto" value="Go" /> + <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page | html %]" size="4" type="text" /><input type="submit" name="changepage_goto" value="Go" /> </form>
<p><form method="get" action="/cgi-bin/koha/cataloguing/z3950_auth_search.pl"><input type="hidden" name="authid" value="[% authid | html %]" /><input type="submit" value="Try another search"/></form></p> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt index b52a283..6216c99d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt @@ -174,7 +174,7 @@ [% IF ( show_nextbutton ) %] <input type="button" name="changepage_next" value="Next page" data-currentpage="[% current_page | html %]" /> [% END %] - <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page | html %]" size="4" /><input type="submit" name="changepage_goto" value="Go" /> + <br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page | html %]" size="4" type="text" /><input type="submit" name="changepage_goto" value="Go" /> </form>
[% ELSE %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt index adc3cf1..01e25b2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt @@ -152,7 +152,7 @@ </li> <li> <label for="barcode">Enter barcode: </label> - <input name="barcode" id="barcode" size="15" class="focus" /> <input type="submit" value="Submit" /> + <input name="barcode" id="barcode" size="15" class="focus" type="text" /> <input type="submit" value="Submit" /> </li> </ol> </fieldset> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt index 3bd92c2..4cd0174 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt @@ -94,7 +94,7 @@ <fieldset> <legend>Check In</legend> <label for="checkin-barcode">Enter item barcode: </label> - <input name="barcode" id="checkin-barcode" size="14" class="focus"/> + <input name="barcode" id="checkin-barcode" size="14" class="focus" type="text" /> <input type="submit" class="submit" value="Submit" /> </fieldset> </div> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt index 11c3eca..39c6b70 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt @@ -153,7 +153,7 @@
<label for="barcode">Enter item barcode: </label>
- <input name="barcode" id="barcode" size="14" class="focus"/> + <input name="barcode" id="barcode" size="14" class="focus" type="text" />
<input type="submit" class="submit" value="Submit" /> </fieldset> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt index 74b24f6..e1949f0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ -611,11 +611,11 @@ <legend>Check in</legend> <label for="barcode">Enter item barcode: </label> [% IF ( exemptfine ) %] - <input name="barcode" id="barcode" size="14" class="focus alert"/> + <input name="barcode" id="barcode" size="14" class="focus alert" type="text" /> [% ELSIF ( dropboxmode ) %] - <input name="barcode" id="barcode" size="14" class="focus alert"/> + <input name="barcode" id="barcode" size="14" class="focus alert" type="text" /> [% ELSE %] - <input name="barcode" id="barcode" size="14" class="focus"/> + <input name="barcode" id="barcode" size="14" class="focus" type="text" /> [% END %] <input type="submit" class="submit" value="Submit" />
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt index e5b34e1..35570e7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ -969,7 +969,7 @@ <legend id="manual_restriction_lgd">Add manual restriction</legend> <ol> <li><label for="debarred_comment">Comment: </label><input type="text" id="debarred_comment" name="debarred_comment" onchange="$('#add_debarment').val(1);" /></li> - <li><label for="debarred_expiration">Expiration: </label><input name="debarred_expiration" id="debarred_expiration" size="10" value="" class="datepicker" onchange="$('#add_debarment').val(1);" /> + <li><label for="debarred_expiration">Expiration: </label><input name="debarred_expiration" id="debarred_expiration" size="10" value="" class="datepicker" onchange="$('#add_debarment').val(1);" type="text" /> <a href='javascript:void(0)' onclick="$('#debarred_expiration').val('');">Clear date</a></li>
</ol> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt index 14384b3..2f8e1fb 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ -101,7 +101,7 @@ <li> <label for="paid">Collect from patron: </label> <!-- default to paying all --> - <input name="paid" id="paid" value="[% amountoutstanding | html %]" /> + <input name="paid" id="paid" value="[% amountoutstanding | html %]" type="text" /> </li> [% SET payment_types = AuthorisedValues.GetAuthValueDropbox('PAYMENT_TYPE') %] [% IF payment_types %] @@ -157,7 +157,7 @@ <li> <label for="paid">Writeoff amount: </label> <!-- default to writing off all --> - <input name="amountwrittenoff" id="amountwrittenoff" value="[% amountoutstanding | $Price on_editing => 1 | html %]" /> + <input name="amountwrittenoff" id="amountwrittenoff" value="[% amountoutstanding | $Price on_editing => 1 | html %]" type="text" /> </li> </ol> </fieldset> @@ -198,7 +198,7 @@ <label for="paid">Collect from patron: </label> [% END %] <!-- default to paying all --> - <input name="paid" id="paid" value="[% total | format('%.2f') %]" /> + <input name="paid" id="paid" value="[% total | format('%.2f') %]" type="text" /> </li> [% SET payment_types = AuthorisedValues.GetAuthValueDropbox('PAYMENT_TYPE') %] [% IF payment_types %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index bf6220d..afbacf3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -219,14 +219,14 @@ [% IF ( reserve_in_future ) %] <li> <label for="from">Hold starts on date:</label> - <input name="reserve_date" id="from" size="10" class="datepickerfrom"> + <input name="reserve_date" id="from" size="10" class="datepickerfrom" type="text" > <a href="#" id="clear-date-from" class="clear-date">Clear date</a> </li> [% END %]
<li> <label for="to">Hold expires on date:</label> - <input name="expiration_date" id="to" size="10" class="datepickerto" /> + <input name="expiration_date" id="to" size="10" class="datepickerto" / type="text" > <a href="#" id="clear-date-to" class="clear-date">Clear date</a> </li>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt index 4e0a4b0..8165027 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt @@ -188,7 +188,7 @@ [% CASE %] <li> <label class="description" for="[% borrower_field.field | html %]">[% borrower_field.description | html %]: </label> - <input id="[% borrower_field.field | html %]" name="[% borrower_field.field | html %]" /> + <input id="[% borrower_field.field | html %]" name="[% borrower_field.field | html %]" type="text" /> <span class="field_hint">[% borrower_field.field | html %]</span> </li> [% END %] @@ -197,7 +197,7 @@ [% IF ( Koha.Preference('ExtendedPatronAttributes') == 1 ) %] <li> <label class="description" for="patron_attributes">Patron attributes: </label> - <input id="patron_attributes" name="patron_attributes" /> + <input id="patron_attributes" name="patron_attributes" type="text" /> <span class="field_hint">patron_attributes</span> </li> [% END %] -- 2.1.4
-- You are receiving this mail because: You are watching all bug changes.