http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Final QA Comments: Keeping fetchrow close to its execute worked even better in GetReserveStatus. Instead of returning undef, I return empty string. I checked all calls; this value is mostly not checked for undef. So we eliminate a lot of warnings in log. Instead of harassing Jonathan again, I added a followup myself.
From opac include item-status.inc: [% ELSIF ( item.waiting ) %] On hold Funny thing: If you set waiting=1, the message is On hold. If you set onhold=1 (for a pending reserve), the variable is not used. Conclusion is probably that the line in opac-detail setting var onhold, is not needed.. Can be handled later or somewhere else..
Passed QA -- You are receiving this mail because: You are watching all bug changes.