https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34666 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #14)
(In reply to Marcel de Rooy from comment #13)
(In reply to Nick Clemens from comment #12)
(In reply to Marcel de Rooy from comment #11)
Please fetch latest qa tools:
WARN t/db_dependent/Reserves.t OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 510, now: 515) OK valid
Fresh KTD, pulled - qa-tools pulled - I get tidiness warnings (often) but not for these patches. Do you have other patches applied?
Interesting. I remember a discussion earlier if there is a difference between the Koha git repo perltidyrc and the one used in KTD. Could you compare them? I am just using the git repo perltidyrc.
I only find the one file
Tomas: In view of above, could you confirm that KTD uses the perltidyrc from the root directory of the Koha git repo ? cat .perltidyrc # delete backup if no errors --backup-file-extension='/' --character-encoding=utf8 --output-line-ending=unix --iterations=2 # } else { --cuddled-else # Use the full indent size for continuations --continuation-indentation=4 --no-outdent-long-lines --maximum-line-length=120 --break-at-old-comma-breakpoints And which version, Nick? root@master:/usr/share/koha# perltidy -v This is perltidy, v20230309 -- You are receiving this mail because: You are watching all bug changes.