http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 26262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26262 Bug 11651: Add possibility to print holds from holds queue Review of attachment 26262: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11651&attachment=26262) ----------------------------------------------------------------- Please take a look at the following. Marked as Failed QA. ::: C4/HoldsQueue.pm @@ +47,5 @@
&TransportCostMatrix &UpdateTransportCostMatrix + + &MarkHoldPrinted + &GetItemNumberFromTmpHold
New unit tests should be provided for these 2 new subroutines. @@ +136,5 @@
+ if (C4::Context->preference('printSlipFromHoldsQueue')){ + $query .= $branchlimit ? " AND" : " WHERE"; + $query .= " tmp_holdsqueue.print_status = ?"; + push @bind_params, $printstatus; + }
New unit tests should be provided for this subroutine change. ::: C4/Reserves.pm @@ +2255,5 @@
+ 'biblio' => $reserve->{biblionumber}, + 'items' => $itemnumber, + }, + ); +}
At least one unit test should be provided for this new subroutine. ::: circ/hold-pull-print.pl @@ +12,5 @@
+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License along +# with Koha; if not, write to the Free Software Foundation, Inc., +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
License should be GPLv3. @@ +15,5 @@
+# with Koha; if not, write to the Free Software Foundation, Inc., +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + +use strict; +#use warnings; #FIXME - Bug 2505
replace use strict/warnings with use Modern::Perl. ::: circ/view_holdsqueue.pl @@ +76,4 @@
$template->param( branchloop => GetBranchesLoop(C4::Context->userenv->{'branch'}), itemtypeloop => \@itemtypesloop, + printenable => C4::Context->preference('printSlipFromHoldsQueue'),
Same as previously. ::: installer/data/mysql/updatedatabase.pl @@ +8071,5 @@
+ $dbh->do("ALTER TABLE old_reserves ADD print_status BOOLEAN NOT NULL DEFAULT '0'"); + $dbh->do("ALTER TABLE tmp_holdsqueue ADD print_status BOOLEAN NOT NULL DEFAULT '0'"); + $dbh->do("ALTER TABLE tmp_holdsqueue ADD reserve_id INT ( 11 ) FIRST"); + $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('printSlipFromHoldsQueue', '0', 'NULL', 'If enabled reserve slips can be printed from Holds Queue screen,', 'YesNo');"); + print "Upgrade to $DBversion done \n";
you forgot the SetVersion call here. ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt @@ +44,5 @@
+ for (var i=0; i < document.hold_print.reserve_id.length; i++) { + document.hold_print.reserve_id[i].checked=false; + } + } +}
you can use [un]checkCheckboxes functions provided by jquery.checkboxes.min.js to do that. @@ +93,2 @@
[% IF ( itemsloop ) %] + <form id="hold_print" name="hold_print" method="get" action="/cgi-bin/koha/circ/hold-pull-print.pl" target="_blank">
why do you use target="_blank" here? @@ +142,5 @@
</tr> [% END %]</tbody> </table> + [% IF ( printenable ) %] + </form>
This close tag is in a IF but not the <form>. -- You are receiving this mail because: You are watching all bug changes.