https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #33)
Hi Jonathan,
Hi Katrin, thanks for your feedback!
starting QA here - not only a RM priority, but one of mine as well. I will try to come back at this as long as necessary:
1) QA test tools:
There are some about POD, but I think those are valid:
FAIL admin/authorised_values.pl FAIL valid Can't locate Carp/Always.pm in @INC (you may need to install the Carp::Always module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/kohadev/plugins)
All issues related with Carp::Always will be resolved by a follow-up patch.
FAIL Koha/AuthorisedValues.pm
FAIL valid Name "Koha::Schema::Result::AuthorisedValue::LANGUAGE" used only once: possible typo
Not valid, it's what we are doing for Itemtype.pm
2) Code review
a) C4/Search.pm + $facet_label_value = $av->count ? $av->next->opac_translated_description : ''; # FIXME: Why are we displaying the opac description for staff?
I believe you are right here - this is a bug. Could be fixed here or later. Why are we not dealing with this in the templates?
Because we are in C4::Search :-/
b) Koha/AuthorisedValue.pm
opac_translated_description and tranlated_description seem to have a lot of duplicated code. Coudl it make sense to merge them with an interface parameter?
IMO it's more readable as it, but could be discussed.
+ my $descriptions = { + lib => $av->translated_description, # Rename with opac_translated_description to avoid confusion + opac_description => $av->opac_translated_description # Same with translated_description + };
Not sure what you meant with your comments here?
They do not make sense, I guess it's a c/p failure from Koha/Template/Plugin/AuthorisedValues.pm
3) Testing
The admin page currently explodes:
Could not compile /home/vagrant/kohaclone/admin/authorised_values.pl: Can't locate Carp/Always.pm in @INC (you may need to install the Carp::Always module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer /home/vagrant/kohaclone/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/kohadev/plugins) at /home/vagrant/kohaclone/admin/authorised_values.pl line 27. BEGIN failed--compilation aborted at /home/vagrant/kohaclone/admin/authorised_values.pl line 27. at /usr/share/perl5/CGI/Compile.pm line 132
Because of missing Carp::Always, but I removed it now.
As I understand it, this is just the 'base' and then we will have to work through the different AV categories... that about right?
Nope, it should work for any AV. -- You are receiving this mail because: You are watching all bug changes.