https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #13 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to M. Tompsett from comment #12)
My mistake. Colin is correct. misc/cronjobs/edi_cron.pl calls process_quote() in Koha::EDI, which calls quote_item in Koha::EDI. As far as I can tell there is no other way to trigger quote_item. And so, I believe the original patch was more correct, in that it is simpler. So apologies for any frustrations.
*IF* in the future, someone wanted to manually integrate EDI quote processing -- it would be useful to see debugging feedback step by step -- Kyle's patch makes sense.
However, I still believe there should be test coverage. There is no test coverage of Koha::EDI. This needs to be solved. It is a serious hole. Test coverage for quote_item and/or process_quote would be good, leaving Failed QA.
patch reinstates a call to C4::Context - do we need another test to show that works? QA failed not for this patch, but for more global concerns, I'd argur thats counterproductive - or shall we just remove this functionality from Koha -- You are receiving this mail because: You are watching all bug changes.