https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #63 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #60)
Yes sure, I agree. I will implement that as soon as this is PQA.
The latest work still seems like work-in-progress to me? - Connection details and credentials are still hard-coded into Koha::BackgroundJob, and there is no way of passing in a virtual host (which we might not use out of the box, but it would be good to build in the support) - For instance, koha_worker.pl should be moved to "./misc/bin/koha_worker.pl". - I was thinking the "namespace" for the queues should use the database name instead, since non-Debian installs may or may not have correctly set memcached_namespace. - I don't think there's any service to start up koha_worker.pl? - I'm curious why koha_worker.pl doesn't use the /queue prefix (as suggested by https://www.rabbitmq.com/stomp.html). I think it works without it, as I have tested your patches, but I'm curious. - Could we use a "/" instead of a "-" for the queue destination. I think that would be more conventional. - Koha::BackgroundJob loads C4::MarcModificationTemplates and C4::Biblio but doesn't use them. I'd really like to see this code be plugin friendly from Day 1, which I think could be done with some updates to koha_worker.pl and Koha::BackgroundJob. At the moment, koha_worker.pl and Koha::BackgroundJob are hard-coded with 2 job_types. It wouldn't be difficult to move the job_types somewhere more configurable. -- You are receiving this mail because: You are watching all bug changes.