http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23741|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24521&action=edit Bug 11056 : Delete dead code in basketgroup.pl In basketgroup.pl, some code is supposed to be executed if $op = "validate". But this value is no more assigned to $op variable since 2009. This patch suppressed dead code, along with parseinputbaskets and parseinputbasketgroups subs, which are obsolete. No functional changes expected Regression test : Check basketgroup are shown as before the patch, and can be closed and reopen. Check you can add or remove a basket from a basketgroup, and change informations about it (like delivery place) Check you can create a basketgroup when you close a basket. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> The following commands return nothing: - grep validate acqui/basketgroup.tt - grep -R basketgroup.pl -C 2 | grep validate - git grep parseinputbaskets - git grep parseinputbasketgroups - git grep basketgroup.pl | grep validate -- You are receiving this mail because: You are watching all bug changes.