http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #44 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- (In reply to Bernardo Gonzalez Kriegel from comment #35)
(In reply to M. Tompsett from comment #34)
I'd start at comment 25. :)
* GetItemsInfo() is getting called in t/db_dependent/Items.t: bug_11213: GetItemsInfo() test * searchResults() is already being called from t/db_dependent/Search.t; XSLTResultsDisplay pref handling in the test should make sure the code is visited: bug_11213: Include XSLT processing for searchResults() test * shelfpage() did not have a test, and I can add one * XSLTParse4Display() is being explicitly called in t/db_dependent/Items.t
Mmmm, I can finish right now.
My friends, what I expect is a clear list of what needs to be tested, or run, and what to expect as result. In that way it's easier. In it's current state is discouraging.
Clear list of what is expected is impossible, at least for me, to give. I cannot even imagine in what different ways particular configs can affect XSLT display. The best I can do is: * Create tests that should pass. In this case we have (in t/db_dependent): Items.t Search.t VirtualShelves_Page.t (will add shelfpage() call) * Ask for XSLT display on OPAC and Intranet related pages to be checked, which includes: - search results - individual biblio + items display - virtual shelves
Anyway, 1) In it's current state patch doesn't apply. Some patches have been pushed that gave conflicts. I solved all but I prefer the author have the last word on this
Rebased
2) prove t/db_dependent/VirtualShelves_Page.t t/db_dependent/VirtualShelves_Page.t .. 1/3 # Failed test 'opac items XSLT' # at t/db_dependent/VirtualShelves_Page.t line 48. Please fix and resubmit.
That one worked for me after rebase. Can you please try again. -- You are receiving this mail because: You are watching all bug changes.