https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34498 --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Emily Lamancusa (emlam) from comment #6)
Thanks for the explanation, Aleisha!
Sorry it's taken so long to get back to you!
I think there are two pieces here: One is that the checkout code should be checking ItemsDeniedRenewal, and not setting issues.auto-renew in the first place if its renewal is denied by the syspref. Then the cron wouldn't pick up those items, and we wouldn't need a separate loop to exclude them.
That sounds reasonable.
For the notices issue, we have something similar - it's not specific to ItemsDeniedRenewal, but in our system we generally don't want an auto-renewal notice going out at all if nothing actually renewed. To prevent that, we wrapped our notice template in: [%- UNLESS success == 0 %] <notice template contents> [%- END %]
Would something like that work for this library's use case?
I think that would've been an effective workaround for their use case. -- You are receiving this mail because: You are watching all bug changes.