https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #29)
I'm with Tomas here, whilst it would be nice to move _FixPriority, I think it's well tested and we should focus on modernising and moving the functions that use it first.. and then move/modernise that last as it's own step.
It's a big block of code and I feel that perhaps some of it can/should be updated to be a trigger on the Koha::Hold->store method eventually.. but I think splitting it like that at this point prior to the rest of our methods moving is actually more of a risk.
Lets march forward and keep the momentum going on this.
I'm already looking at _FixPriorities. It looks like it does too much (cancelling a hold?) and can be simplified a lot. My perception on writing Koha::Hold->fill, is that we will eventually remove things from controllers and, for example, we could end-up passing the Koha::Item to this new method. I'm pondering (for bug 29891): - Koha::Biblio->fix_holds_priorities, that would call $self->holds->unfilled->fix_priorities - Koha::Holds->fix_priorities (that acts on the resultset) -- You are receiving this mail because: You are watching all bug changes.