https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42126 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195619&action=edit Bug 42126: Make 00-strict.t run strict on all Perl files The current implementation is wrong: * we list explicitly the directories to process and it's not kept up-to-date (eg. booking and Koha are missing). * we should process the files that are in the git repository, and use Koha::Devel::Files to list them. This patch suggests to use git ls-files (through Koha::Devel::Files) and process them one by one. Also only call strict_ok instead of all_perl_files_ok. all_perl_files_ok was doing strict_ok and syntax_ok, but syntax_ok is doing a `perl -c` that is done in xt/pl_valid.t already We can ignore xt and t: the tests are... run by the test suite. On main: Files=1, Tests=1360, 287 wallclock secs ( 0.05 usr 0.02 sys + 1677.26 cusr 268.46 csys = 1945.79 CPU) real 4m46.741 all_perl_files_ok with t and xt: Files=1, Tests=3488, 884 wallclock secs ( 0.10 usr 0.01 sys + 3820.09 cusr 720.63 csys = 4540.83 CPU) real 14m44.086s all_perl_files_ok without t and xt: Files=1, Tests=2666, 586 wallclock secs ( 0.08 usr 0.03 sys + 2261.22 cusr 447.02 csys = 2708.35 CPU) 9m46.519s With this patch (syntax_ok without t and xt): Files=1, Tests=2663, 337 wallclock secs ( 0.09 usr 0.01 sys + 76.18 cusr 70.32 csys = 146.60 CPU) real 5m36.870s Note that Koha/Account/Credit.pm, Koha/Account/Debit.pm and Koha/Old/Hold.pm are failing strict_ok, we ignore them for now: Inconsistent hierarchy during C3 merge of class 'Koha::Account::Credit': current merge results [ Koha::Account::Credit, ] merging failed on 'Koha::Account::Line' at /usr/lib/x86_64-linux-gnu/perl-base/base.pm line 186. BEGIN failed--compilation aborted at Koha/Account/Credit.pm line 22. -- You are receiving this mail because: You are watching all bug changes.