http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #83 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 19250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19250&action=edit DBIx::Class tests: replacing GetBranchName by it's DBIx::Class equivalent In this patch, I choose to overload the C4/Branch.pm/GetBranchName by it's DBIx::Class equivalent It's just a POC, no need to commit this patch. the question behind the patch is: should we * REMOVE GetBranchName by replacing all the calls by Koha::BusinessLogic::Branch->read({'branchcode' => $branchcode})->first->branchname; * overload the sub and make it die later I think the 1st will require more effort, but better, while the second requires less effort, but result in much less code cleaning My preference would go to the 1st option. -- You are receiving this mail because: You are watching all bug changes.