https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44193 --- Comment #2 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 212429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=212429&action=edit Bug 44193: Do not mark a found copy lost when its lost charge is paid When a LOST charge was paid (or written off) in full, apply() set the item to UpdateItemLostStatusWhenPaid (or UpdateItemLostStatusWhenWriteOff) without checking that it was still lost. A copy returned while its charge was kept ("Leave lost item charge", or after NoRefundOnLostReturnedItemsAge) went back to lost when the patron paid, although it was on the shelf. The status is now only changed while the copy is still lost. Test plan: 1. prove t/db_dependent/Circulation.t The new subtest "Paying or writing off a lost charge does not mark a found copy lost again" fails without the patch (itemlost becomes 3 and 4). 2. In the staff interface: a. UpdateItemLostStatusWhenPaid = "Lost and paid for". b. Circulation and fines rules, Lost item fee refund on return policy: Refund lost item replacement fee = "Leave lost item charge". c. Check an item out, mark it lost (a LOST charge is added), check it in: the item is not lost, the charge is still outstanding. d. Pay the LOST charge in full. e. Without the patch the item is "Lost and paid for" again; with the patch it stays available. 3. A copy still lost when its charge is paid is still set to "Lost and paid for" (existing tests). Sponsored-by: Koha Solutions Signed-off-by: John Vinke <jvinke@austinseminary.edu> -- You are receiving this mail because: You are watching all bug changes.