https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #2) Thanks Owen!
I see some issues with this when I compare the behavior in master to the behavior when this patch is applied:
- In master when there are no entries in the dropdown it shows a message in the dropdown, "No matches found." With the new version there is no message.
Indeed. There was a translation issue I have "fixed" now, however the behaviour is still the same. I think it is the expected one, but I have not looked at Select2 code. https://select2.org/upgrading/migrating-from-35#renamed-translation-options See the last patch. I found the list there: https://github.com/select2/select2/blob/develop/dist/js/i18n/en.js I think it's better to continue handling the translation on our side.
- Looking at the basic MARC editor, testing a required subfield (in my test, 952c). Submitting the form causes the HTML <select> to appear above the Select2 control
Fixed.
- The old version let the user select an empty option by clicking an "x" in the control. The new version includes an empty option just like an HTML select would. I think both are reasonable but I wonder if this is something we want to intentionally change.
Restored in the patch "Fix default values" -- You are receiving this mail because: You are watching all bug changes.