[Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #6)

QA Comments:

Looks good to me. Code clean, UT++

Just one thing: maybe it would be better to pass a hashref to parseQuery instead of 7 arguments. But it is possible to have some disagreements about that.

The reasoning behind using the 7 arguments is that parseQuery is still just a shim, so we want it to look as much like buildQuery as possible. When parseQuery replaces buildQuery, the API will also be changed. -- You are receiving this mail because: You are watching all bug changes.