https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #233 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #232)
I'm afraid the DB update fails for a few test runs I've tried.
borrowers.relationship has no constraints to it so it's very possible we have guarantor_relationships without a valid relationship and so the db update fails.
We need to come up with a solution for this before I can push the patch series.. I'm not sure whether to reduce the 'NOT NULL' constraint on the new table or set a default or note the issue as an error somewhere and populate the table with some sort of placeholder relationship whilst libraries work through fixing up the bad data..
Thoughts?
There's no semantic on the relationship field ATM, so I think it being just a label, we should not fail because of it. If we were to add some semantics, we would have a separate table, with the relationship description and probably some columns for describing rules. If such was the situation, I would pick a placeholder as you say, so we don't fail, and even have an entry in about.pl about those problematic cases (maybe a note field with the original value). -- You are receiving this mail because: You are watching all bug changes.