https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This route is kinda horrible.. it's neither a proper PUT or a PATCH.. it allows for setting pickup_location and/or priority and finally allows for suspending but not unsuspending a hold by setting the suspend_until date. There are explicit routes for all those too, which are significantly clearer in my opinion. Jonathans test was indeed incorrect as compared to what the swagger spec allows to be PUT/PATCHed as suspend_until is allowed to be missing but not allowed to be null. So, finally.. I think I can mark this as signed off.. as it's consistent with how things work now. But.. I really don't like it ;P -- You are receiving this mail because: You are watching all bug changes.