https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 122531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122531 Bug 27946: Add article request fee feature Review of attachment 122531: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27946&attachment=122531) ----------------------------------------------------------------- Generally this is looking good :) ::: Koha/ArticleRequest.pm @@ +50,4 @@
my ($self) = @_;
$self->status(Koha::ArticleRequest::Status::Pending); + if(C4::Context->preference('ArticleRequests') && $self->borrower->category->article_request_fee) {
I think the `C4::Context->preference('ArticleRequests')` check here is superfluous to requirements.. I would hope we are checking that the feature is enabled prior to this point and also don't think it makes sense to check them together. @@ +55,5 @@
+ { + amount => $self->borrower->category->article_request_fee, + user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : undef, + interface => C4::Context->interface, + library_id => C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef,
I wonder if this should default to the items home library? I presume there's no requirement, for now at least, for these charges to be library specific? -- You are receiving this mail because: You are watching all bug changes.