http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments: Frere Sebastien Marie suggestions/concern taken in account, passed QA About
You add 2 subs: getbackupfilelist and download_backup => bad point, we usually use capitals (GetBackupFileList and DownloadBackup). However, this is not in a package, so I won't fail QA for that.
Our standard is to use lowercase in .pl files and uppercase in packages, I think. I suppose that makes sense, since it ensures that there will be a visual distinction between local functions and core functions.
You're right, sorry for the annoyance. -- You are receiving this mail because: You are watching all bug changes.