http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #17 from Kyle M Hall <kyle.m.hall@gmail.com> ---
::: t/db_dependent/DecreaseLoanHighHolds.t @@ +92,5 @@
my $patron_hr = { borrower => $patron->id, branchcode => 'MPL' };
my $data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr ); +is( $data->{exceeded}, 1, "Static mode should exceed threshold" ); +is( $data->{outstanding}, 6, "Should have 5 outstanding holds" );
6 vs 5
That is a purposeful change. The issue was that the logic of the unit test was off by one. The assumption was that the number of holds must greater than or equal to, but as per the code and sys pref definition, the number of holds must be simply greater than. Thus adding one more hold fixes all the tests. -- You are receiving this mail because: You are watching all bug changes.