https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Oliver Bock from comment #24)
Warning: I just looked at the patch and didn't apply it.
I think you lack a "$passwd_ok = 1" after checkpw_internal was called as a LDAP-fallback. IOW, the login attempt counter would be increased despite successful internal login after a LDAP bind error.
Yes, I caught that and fixed it in the second version.
Also: - is the "unless ( $passwd_ok ) {" ever closed? - the "} elsif ( $patron ) {" doesn't seem to have a parent if-clause
Other than that your patch seems fine to me.
unless ($cond) { # do stuffs } elsif ($other_cond) { # do other stuff } is a valid perl structure. -- You are receiving this mail because: You are watching all bug changes.