https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I agree, generally. but: 1. You are adding an unadvertised die in C4::Auth (I agree with it!). Please add a test for that behavior. 2. I think you should simplify your patch by just putting the CGI/ dir in the top level. In that case, you would just do what we do for C4, Koha and the OpenILS library directories in Makefile.PL (& friends). No complex hacks. I would love to move all libs to a libs/ dir, but lets do it on a separate bug, and discuss the tradeoffs there (my butt has been kicked a couple times when I proposed it, because of all bugzilla patches not applying if we did that). If you need me to write a follow-up to address my comments, let me know. -- You are receiving this mail because: You are watching all bug changes.