http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Comment on attachment 18388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18388 WIP: HoldsQueue.t needs to create its own data Review of attachment 18388: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10336&attachment=18388) ----------------------------------------------------------------- ::: t/db_dependent/HoldsQueue.t @@ +35,5 @@
+ branchcode => 'CPL', +); + +my $borrowernumber = AddMember(%data); +my $borrower = GetMember( borrowernumber => $borrowernumber );
Looks good -- this also removes the requirement that there be at least one item on loan in the database, which isn't relevant to the functionality being tested. @@ +51,2 @@
$dbh->{AutoCommit} = 0; $dbh->{RaiseError} = 1;
This section should be moved to before the call to AddMember. That way, we don't need to call DelMember to clean up; the rollback will take care of that. @@ +153,5 @@
$dbh->rollback;
+END { + C4::Members::DelMember( $borrowernumber ); +};
Not needed -- see above comment. -- You are receiving this mail because: You are watching all bug changes.