https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #23 from Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> --- Created attachment 208792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208792&action=edit Bug 12620: (QA follow-up) Make do_not_use_proxy a boolean column The QA script reported that the new column z3950servers.do_not_use_proxy is a tinyint(1) without the boolean flag in the DBIC schema, and that the database update was not executable. Also, the schema file had been edited by hand, so its checksum did not match and it could not be regenerated. This patch: - defines the column as tinyint(1) NOT NULL DEFAULT 0 with a comment, in kohastructure.sql and in the database update, which is now executable - regenerates Koha/Schema/Result/Z3950server.pm with DBIx::Class::Schema::Loader and flags the column as boolean An unchecked "Do not use proxy" checkbox sends an empty value, which Koha::Object->store turns into the default value (0). Steps to follow: 1. Apply the patches and run the database update: perl installer/data/mysql/updatedatabase.pl 2. Check the column: SHOW COLUMNS FROM z3950servers LIKE 'do_not_use_proxy'; It is tinyint(1), NOT NULL, default 0. 3. Add <http_forward_proxy>http://localhost:3128</http_forward_proxy> to koha-conf.xml and restart_all. 4. Administration > Z39.50/SRU servers: edit a Z39.50 server, check "Do not use proxy" and save. Edit it again: the checkbox is checked. Uncheck it and save: it is saved as 0 and the checkbox is unchecked. 5. Add a new Z39.50 server without checking the box: it is saved as 0. 6. prove t/db_dependent/Breeding.t 7. The QA script passes for kohastructure.sql, the database update and the schema file. Signed-off-by: Adolfo Rodríguez <adolfo.rodriguez@xercode.es> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.