https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29326 --- Comment #15 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Olli-Antti Kivilahti from comment #3)
Created attachment 188043 [details] [review]
This Bugzilla comment did not explain the change (the feature is explained in the patch commit message), so I will explain it here. It maintains _ALL_ as it is, ie. forcing _ALL_ to overwrite any other setting in the preference. It instead adds a new key, _DEFAULT_, that can be used for a fallback when no other setting was applied. I've added unit tests and while doing so, noticed a Bug in the original patch, so I fixed that as well. This "fix" could be further enhanced. This change renders _ALL_ useless, because the same functionality can be now set with _DEFAULT_. We could replace _ALL_ altogether with _DEFAULT_ with a database update, but it comes with some risk. If a library has currently defined _ALL_ together with other settings, it could cause sudden unexpected consequences. We could add some logic into the replacement, ie. checking if _ALL_ is the only setting (in which case it is OK to replace), or if there are other settings together with _ALL_, remove the others and replace _ALL_ with _DEFAULT_. -- You are receiving this mail because: You are watching all bug changes.