http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9225 Bug ID: 9225 Summary: Subroutines should not be defined in acqui/parcel.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jcamins@cpbibliography.com We should not be declaring subroutines in .pl files. Unfortunately, there are three routines currently declared in acqui/parcel.pl. When run under Plack, this results in the following warnings in the log: Subroutine get_value_with_gst_params redefined at /home/jcamins/kohaclone/acqui/parcel.pl line 74. Subroutine get_gste redefined at /home/jcamins/kohaclone/acqui/parcel.pl line 93. Subroutine get_gst redefined at /home/jcamins/kohaclone/acqui/parcel.pl line 102. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.