http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 29659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29659&action=edit Bug 4162 The inventory tool lacks validation for barcodes The inventory tool had no form of validating on what was assumed to be a valid barcode number. To solve this, an extra loop to read before processing was added. This allows to validate length (<=20 which is the current size of the barcode field in the items table) and content (assumed that 0-9a-zA-Z was good enough). The template was modified to accomodate validation messages related to the length and content errors. TEST PLAN --------- 1) Attempt to select a file which does not contain barcodes and is not a text file. -- a horrible lack of validation and spamminess ensues. 2) Apply patch 3) Create three files. a) One containing valid barcodes on each line -- this file should trigger no errors. b) A copy of the first with an extra line of >20 characters (e.g. The Quick Red Fox Jumped Over The Brown Fence) -- this file should trigger the singular error message case. c) A copy of the second with the last line duplicated -- this file should trigger the plural error message case. 4) Attempt each of the three files. 5) Run koha-qa tools. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.