http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 24597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24597 Bug 10937 - Option to hide and group itemtypes from advanced search Review of attachment 24597: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10937&attachment=24597) ----------------------------------------------------------------- ::: C4/Koha.pm @@ +41,4 @@
&slashifyDate &subfield_is_koha_internal_p &GetPrinters &GetPrinter + &GetItemTypes &GetItemTypesCategorized &GetItemTypesByCategory &getitemtypeinfo
No problem, but I would have put the new functions on a different line, so as to reduce the chance of messing up the old ones. @@ +270,4 @@
} }
+=head2 GetItemTypes
GetItemTypesCategorized. Oops! ::: admin/itemtypes.pl @@ +168,4 @@
$input->param('summary'), $input->param('checkinmsg'), $input->param('checkinmsgtype'), + ( $input->param('hideinopac') ? 1 : 0 ),
This one is in parenthesis? @@ +193,4 @@
$input->param('summary'), $input->param('checkinmsg'), $input->param('checkinmsgtype'), + $input->param('hideinopac') ? 1 : 0,
This one is not? It might be best to avoid the inline expr?true:false in this list. ::: installer/data/mysql/kohastructure.sql @@ +1241,5 @@
summary text, -- information from the summary field, may include HTML checkinmsg VARCHAR(255), -- message that is displayed when an item with the given item type is checked in checkinmsgtype CHAR(16) DEFAULT 'message' NOT NULL, -- type (CSS class) for the checkinmsg, can be "alert" or "message" + hideinopac tinyint(1) NOT NULL DEFAULT 0, -- Hide the item type from the search options in OPAC + searchcategory varchar(15) default NULL, -- Group this item type with others with the same value on OPAC search options
How did you decide on varchar(15)? ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt @@ +146,3 @@
[% itemtypeloo.description %]</label></div> [% IF ( loop.last ) %]</div>[% ELSE %][% UNLESS ( loop.count % 4 ) %]</div><div class="row-fluid">[% END %][% END %] + [% END %]
This END isn't even the area you were adding your IF around. Why change the indentation? Indentation issues should perhaps be a separate patch. -- You are receiving this mail because: You are watching all bug changes.