https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43911 Bug ID: 43911 Summary: Cashup payment types should respect PAYMENT_TYPE library limitations Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Point of Sale Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: martin.renvoize@openfifth.co.uk Target Milestone: --- Bug 33501 lets a library choose which PAYMENT_TYPE authorised values take part in cashup reconciliation, using the CashupPaymentTypes system preference. That preference is global, and the cashup code reads the PAYMENT_TYPE values without looking at their library limitations. Elsewhere PAYMENT_TYPE values are limited by library: the payment type drop-downs use AuthorisedValues.GetAuthValueDropbox, which calls search_with_library_limits for the logged-in library, so a type limited to library A is not offered at library B. Koha::Cash::Register->cashup_payment_types and cashup_payment_types_breakdown do not apply the same rule. A register at library B therefore still lists, and asks staff to count, a payment type that library B cannot take. Expected: when reconciling a register's cashup, only the types in CashupPaymentTypes that are available at the register's library are listed in the Complete cashup modal, in "Bankable by payment type" and in the per-type reconciliation. A Quick cashup builds its balanced list from the same set. Open question: takings already recorded against a type that is not available at the register's library must not silently drop out of the cashup, so I suggest keeping a type in the list when the register has outstanding takings of that type. Test plan: 1. Set UseCashRegisters and set CashupPaymentTypes to CASH,CHEQUE. 2. In the PAYMENT_TYPE authorised values, limit CHEQUE to library A only. 3. Create a register at library B and take a CASH payment on it. 4. At library B open the register page, click Record cashup, then Start cashup and Complete cashup. => Before: a CHEQUE row appears in the modal and in Bankable by payment type. => After: only CASH appears. 5. Repeat at library A: both CASH and CHEQUE appear. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.